Skip to content

don't open freezer for wasm and arbitrumdata databases #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2025
Merged

don't open freezer for wasm and arbitrumdata databases #3828

merged 3 commits into from
Oct 14, 2025

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Oct 14, 2025 •
edited
Loading

Resolves NIT-4010

The behaviour of upstream database API changed and database freezer was started for every opened database. wasm and arbitrumdata databases do not support freezing and starting freezers for them resulted in logging each minuteHead block is not reachable warning for each of those database.

This PR uses new node.DatabaseOptions.NoFreezer config to open wasm and arbitrumdata databases without freezer.

Pulls: OffchainLabs/go-ethereum#560

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2140 3 2137 0
View the top 3 failed tests by shortest run time 
TestVersion30
Stack Traces | 7.130s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:90: goroutine 455215 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40822f0, 0xc0793996c0}, {0x4040520, 0xc13c7bf020}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0793996c0, {0x4040520, 0xc13c7bf020}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0793996c0, 0x1e, {0xc08aaefdb0, 0x6, 0x4f5dc9?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc0793996c0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc0793996c0, 0x3cca840)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (7.13s)

TestVersion40
Stack Traces | 8.180s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[38;5;48;1myay!! we validated block 39 in 223.26ms�[0;0m
�[38;5;48;1myay!! we validated block 2 in 57.41ms�[0;0m
    precompile_inclusion_test.go:90: goroutine 455216 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40822f0, 0xc079399880}, {0x4040520, 0xc13c7bee10}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc079399880, {0x4040520, 0xc13c7bee10}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc079399880, 0x28, {0xc08ff95df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc079399880?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc079399880, 0x3cca848)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (8.18s)

TestEthSyncing
Stack Traces | 78.580s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
TRACE[10-14|17:43:07.486] Handled RPC response                     reqid=7990  duration=882ns
INFO [10-14|17:43:07.486] New Key                                  name=User              Address=0x7E23C8862920797d81916d62c274dd9217113e28
DEBUG[10-14|17:43:07.486] Served eth_getBlockByNumber              reqid=3541  duration="93.014µs"
DEBUG[10-14|17:43:07.486] Executing EVM call finished              runtime="176.682µs"
DEBUG[10-14|17:43:07.486] Served eth_getBlockByNumber              reqid=7992  duration="101.891µs"
TRACE[10-14|17:43:07.486] Handled RPC response                     reqid=3541  duration="1.543µs"
TRACE[10-14|17:43:07.486] Handled RPC response                     reqid=160   duration="2.545µs"
DEBUG[10-14|17:43:07.486] Served eth_call                          reqid=7991  duration="224.101µs"
INFO [10-14|17:43:07.486] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
INFO [10-14|17:43:07.486] State schema set to default              scheme=path
DEBUG[10-14|17:43:07.486] Served eth_getBlockByNumber              reqid=15107 duration="103.965µs"
WARN [10-14|17:43:07.486] Head block is not reachable
DEBUG[10-14|17:43:07.486] Current full block not old enough to freeze err="freezing threshold is not available"
TRACE[10-14|17:43:07.486] Handled RPC response                     reqid=7992  duration="1.332µs"
TRACE[10-14|17:43:07.487] Handled RPC response                     reqid=7991  duration="1.593µs"
DEBUG[10-14|17:43:07.487] Served eth_getBlockByNumber              reqid=29    duration="124.313µs"
DEBUG[10-14|17:43:07.487] Served eth_getBlockByNumber              reqid=161   duration="118.272µs"
TRACE[10-14|17:43:07.487] Handled RPC response                     reqid=15107 duration="3.065µs"
--- FAIL: TestEthSyncing (78.58s)
DEBUG[10-14|17:43:07.490] Stored state history                     id=1                  block=0   data=0.00B   index=858.00B elapsed="40.466µs"

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@magicxyyz magicxyyz marked this pull request as ready for review October 14, 2025 18:22
ganeshvanahalli
ganeshvanahalli approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magicxyyz magicxyyz requested a review from tsahee October 14, 2025 18:41
@magicxyyz magicxyyz mentioned this pull request Oct 14, 2025
Merged
joshuacolvin0 added a commit that referenced this pull request Oct 14, 2025
@joshuacolvin0
Merge pull request #3832 from OffchainLabs/3828-backport
6fc695a 
backport #3828: don't open freezer for wasm and arbitrumdata databases
@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Oct 14, 2025
Merged via the queue into master with commit 4ae76a3 Oct 14, 2025
26 checks passed
@joshuacolvin0 joshuacolvin0 deleted the no-freezer-config branch October 14, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eljobe eljobe eljobe approved these changes

@ganeshvanahalli ganeshvanahalli ganeshvanahalli approved these changes

@KolbyML KolbyML Awaiting requested review from KolbyML

@tsahee tsahee Awaiting requested review from tsahee

Assignees

@tsahee tsahee

Labels

design-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@magicxyyz @eljobe @ganeshvanahalli @joshuacolvin0 @tsahee